-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chashsubset backend with canary #7235
Fix chashsubset backend with canary #7235
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @weiwu-sre! |
Hi @weiwu-sre. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@weiwu-sre: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
Can this PR be superseded by #7169? |
I don't think so. My PR fixes issue with setting alternative backend in chashsubset balancer. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle active |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, weiwu-sre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix chashsubset backend with canary * use floor for buckets calculation to remove hot spot * Remove testing code
Summary
chashsubset is ignoring traffic shaping policy and alternative backends. This PR fixes this issue by assigning traffic shaping policy and alternative backends to chashsubset backend.
What this PR does / why we need it:
Alternative backend and traffic shaping policy works on chash backend. But not chashsubset backend.
For example, when we configure
nginx.ingress.kubernetes.io/upstream-hash-by-subset
on ingress. Our canary ingress stop receiving traffic.Types of changes
How Has This Been Tested?
nginx.ingress.kubernetes.io/canary-by-header: X-CANARY
X-CANARY: always
make sure calls are routed to canary serviceMain Service Yaml
Canary Service Yaml
Checklist: